We should support utf8-invalid filenames
Bug #368626 reported by
Facundo Batista
This bug affects 62 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Client |
Fix Released
|
High
|
Ubuntu One Foundations+ team | ||
ubuntuone-client (Ubuntu) |
Fix Released
|
Medium
|
Ubuntu One Foundations+ team |
Bug Description
If the user creates a file with a name that is not utf8 valid, we should ignore it (and alert the user that he has a problem there, for him to solve it)
You can find invalid filenames using the following script: http://
Related branches
lp:~facundo/ubuntuone-client/ignore-nonutf8-filenames
- dobey (community): Approve
- Natalia Bidart (community): Approve
-
Diff: 511 lines (+225/-35)6 files modifieddata/source_ubuntuone-client.py (+2/-0)
tests/syncdaemon/test_dbus.py (+17/-0)
tests/syncdaemon/test_eq_inotify.py (+158/-35)
ubuntuone/syncdaemon/dbus_interface.py (+14/-0)
ubuntuone/syncdaemon/event_queue.py (+25/-0)
ubuntuone/syncdaemon/logger.py (+9/-0)
Changed in ubunet: | |
assignee: | nobody → Lucio Torre (lucio.torre) |
status: | Confirmed → Triaged |
tags: | added: foundations+ |
affects: | ubunet → ubuntuone-client |
visibility: | private → public |
tags: | added: facundo-lucid |
tags: |
added: chicharra-lucid-problems removed: facundo-lucid |
tags: | added: u1-lucid |
tags: | added: rye-diag |
Changed in ubuntuone-client: | |
status: | Triaged → Fix Committed |
assignee: | Lucio Torre (lucio.torre) → nobody |
assignee: | nobody → Bongcaivang (bongcaivang) |
Changed in ubuntuone-client: | |
assignee: | Facundo Batista (facundo) → Ubuntu One Foundations+ team (ubuntuone-foundations+) |
description: | updated |
tags: | added: package |
Changed in ubuntuone-client: | |
milestone: | none → lucid-beta-2 |
Changed in ubuntuone-client (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Ubuntu One Foundations+ team (ubuntuone-foundations+) |
milestone: | none → ubuntu-10.04-beta-2 |
Changed in ubuntuone-client: | |
status: | Triaged → In Progress |
Changed in ubuntuone-client (Ubuntu): | |
status: | Triaged → In Progress |
Changed in ubuntuone-client (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in ubuntuone-client: | |
status: | In Progress → Fix Committed |
Changed in ubuntuone-client (Ubuntu): | |
status: | Fix Committed → Fix Released |
tags: | removed: package |
Changed in ubuntuone-client: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
You probably want to stick with UTF-8 in ubunet and simply validate that any client software submissions to the database (via u1-storage- protocol, or updown/webui) *are* valid UTF-8.. and leave it up to the client applications to perform any double encoding.
Making any changes to let badly formatted string in now, will likely cause trouble later.