[PATCH] Focus name field on user page

Bug #241367 reported by Michael Terry
2
Affects Status Importance Assigned to Milestone
oem-config (Ubuntu)
Fix Released
Medium
Colin Watson
ubiquity (Ubuntu)
Fix Released
Medium
Colin Watson

Bug Description

Binary package hint: oem-config

When switching to the last page (the user setup page) the Forward button is disabled, and thus the focus isn't on anything useful. The following trivial patch sets it on the user's name field.

Tags: oem-services
Revision history for this message
Michael Terry (mterry) wrote :
Revision history for this message
Colin Watson (cjwatson) wrote :

This might solve the immediate problem, but I'm concerned that there's something else wrong if focus isn't being set to the first focusable widget on the page when the sensitivity of the Forward button is tweaked. If GTK+ doesn't deal with this automatically, then I think we should adjust for this in a generic way in allow_change_step and allow_go_forward instead.

Changed in oem-config:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Michael Terry (mterry) wrote :

When you switch pages, it's possible to end up with *no* focused widget. I've attached a small patch that checks for this generically in on_next_clicked and on_back_clicked.

Why we end up with no focus widget is not clear to me. It might be something GtkAssistant is doing.

Revision history for this message
Colin Watson (cjwatson) wrote :

Thanks! I've committed this to both oem-config and ubiquity (the latter suffered from a similar problem).

Changed in ubiquity:
importance: Undecided → Medium
status: New → Triaged
Changed in oem-config:
assignee: nobody → kamion
status: Triaged → Fix Committed
Changed in ubiquity:
assignee: nobody → kamion
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 1.9.7

---------------
ubiquity (1.9.7) intrepid; urgency=low

  [ Evan Dandrea ]
  * Properly fix intltool dependency. Remove old copies of intltool
    scripts.
  * Add an auto-login option to the "Who are you?" page.

  [ Michael Terry ]
  * Ensure that some widget is focused after changing page (LP: #241367).

  [ Colin Watson ]
  * Add a no-op compatibility shim for depmod. Some d-i code calls it after
    calling anna-install in order to make sure that new kernel modules are
    installed properly; this is unnecessary and slow in the live CD
    environment (LP: #251117).
  * Brown-paper-bag bug: open /target/var/log/installer/oem-id for writing
    (LP: #251751).
  * Update summary page to fetch the language name correctly from the new
    localechooser.
  * Set SCIM_USER and SCIM_HOME to force scim to use configuration and
    sockets from the live CD user rather than root (LP: #234208).
  * Use a single private debconf-communicate instance for five queries in
    base frontend initialisation rather than using the debconf_operation
    wrapper. This is less convenient, but significantly speeds up startup
    (in a kvm instance here, 19 seconds -> 4 seconds).
  * Remove hardcoded invisible_char properties in order to use GTK's
    defaults (LP: #225882).
  * GTK frontend:
    - Don't translate step_label when switching to the language page;
      on_language_treeview_selection_changed will take care of it if
      necessary, and the page-switch handler may not know the correct
      language (LP: #225876).
    - Bind the Delete key on the partition list to "Delete partition"
      (LP: #218936).
  * KDE frontend:
    - Make "Details" string on summary page translatable (LP: #190491).
  * Depend on rdate for clock-setup.
  * Automatic update of included source packages: apt-setup 1:0.37ubuntu3,
    clock-setup 0.96ubuntu1, localechooser 2.03ubuntu2, user-setup
    1.20ubuntu4.

 -- Colin Watson <email address hidden> Sun, 27 Jul 2008 00:13:38 +0100

Changed in ubiquity:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package oem-config - 1.45

---------------
oem-config (1.45) intrepid; urgency=low

  [ Colin Watson ]
  * Restore lost change from 1.38:
    - Don't fail to set the locale if the mirror/country question doesn't
      exist.
  * Add oem to /usr/lib/oem-config/user/reserved-usernames (see LP #251056).
  * Add sensible --version output and output our version to oem-config.log.
  * Automatic update of included source packages: localechooser 2.03ubuntu2,
    user-setup 1.20ubuntu4.

  [ Michael Terry ]
  * Set LANG in /etc/default/locale even if it isn't there already
    (LP: #249550).
  * Ensure that some widget is focused after changing page (LP: #241367).
  * Add an auto-login option, currently GTK-only (LP: #241372).

  [ Evan Dandrea ]
  * Do not try to set localechooser/alreadyrun. It is no longer used.
  * Also remove the langlevel file if it exists before we start
    localechooser.

 -- Colin Watson <email address hidden> Fri, 22 Aug 2008 13:00:18 +0100

Changed in oem-config:
status: Fix Committed → Fix Released
Michael Terry (mterry)
tags: added: oem-services
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.