Code duplication in the Web Client
Bug #904842 reported by
Manuel de la Peña
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
| Stable-4-0 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Low
|
Manuel de la Peña | |||
| ubuntu-sso-client (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | |||
| Quantal |
Fix Released
|
Undecided
|
Unassigned | |||
Bug Description
There is code duplication in the WebClient implementations where the headers and oauth headers are set. The code should be shared by the different implementations.
Related branches
lp:~mandel/ubuntu-sso-client/remove-duplication
- Eric Casteleijn (community): Approve
- Zachery Bir (community): Approve
-
Diff: 129 lines (+34/-39)5 files modifiedubuntu_sso/utils/webclient/common.py (+17/-4)
ubuntu_sso/utils/webclient/libsoup.py (+2/-11)
ubuntu_sso/utils/webclient/qtnetwork.py (+2/-11)
ubuntu_sso/utils/webclient/tests/test_webclient.py (+11/-2)
ubuntu_sso/utils/webclient/txweb.py (+2/-11)
| Changed in ubuntu-sso-client: | |
| status: | New → In Progress |
| importance: | Undecided → Low |
| Changed in ubuntu-sso-client: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-sso-client (Ubuntu Quantal): | |
| status: | New → Triaged |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-sso-client (Ubuntu Quantal): | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-sso-client - 3.99.0-0ubuntu1
---------------
ubuntu-sso-client (3.99.0-0ubuntu1) quantal; urgency=low
* New upstream release.
- Remove some code duplication in web client. (LP: #904842)
- Handle starting with the -testsability argument. (LP: #984964)
- Log more details for SSL validation failure. (LP: #987405)
- Use the new dev-tools API in tests. (LP: #988809)
- Use the network detection page before signup/login. (LP: #996025)
- Fix size of password assistance label in reset dialog. (LP: #999885)
- ubuntu-sso-login-qt crashed with TypeError in got_state. (LP: #1003692)
* debian/control:
- Update dependencies to allow running unit tests during build.
* debian/patches:
- Remove upstreamed patches.
* debian/
- Trap DBusException when connecting to session bus. (LP: #711413)
* debian/
- Tell libsoup to use strict ssl with system ca certs. (LP: #882055)
* debian/rules:
- Enable unit tests during build.
* debian/watch:
- Update to use stable-4-0 series for Quantal.
-- Rodney Dawes <email address hidden> Fri, 15 Jun 2012 16:52:27 -0400