Comment 3 for bug 46447

Revision history for this message
Daniel T Chen (crimsun) wrote : Re: Regarding Ubuntu bug #46447 [grabcd-encode's script has absurdly generic name]

Christian,

The proposed approach sounds quite reasonable. Thanks again!

Dan

----- Original Message ----
From: Christian Garbs <email address hidden>
To: Dan Chen <email address hidden>
Sent: Sunday, December 28, 2008 4:42:47 AM
Subject: Re: Regarding Ubuntu bug #46447 [grabcd-encode's script has absurdly generic name]

On Sat, Dec 27, 2008 at 01:14:23PM -0800, Dan Chen wrote:

> While tending the bug reports for grabcd in Ubuntu, I came across
> this bug[0] that describes the filenames of the main scripts in the
> grabcd source package as being too generic. I made the subsequent
> changes[1] to resolve the bug, but there is concern[2] that such a
> change would break compatibility with existing scripts. While no
> Ubuntu binary packages depend on hardcoded paths provided by
> grabcd's executable scripts, we would like to resolve this bug in a
> manner consistent with upstream's (your) wishes if at all possible.

Hello Dan,

the bus report is right: the script names are terrible.

As the package names are 'grabcd-rib' and 'grabcd-encode', I shall
rename the scripts to:

- grabcd-encode
- grabcd-rip
- grabcd-scan

That way it's consistent among the scripts as well as the package
names.

If the ENCODE_BINARY in the configuration points to the old name
(encode.pl), I will correct it automatically and print out a warning
about it e.g. "encode.pl is now called grabcd-encode, please update
your config, this is corrected for this run".

If you don't find any flaws in this, expect a new version within the
next days.

Regards
Christian
--
....Christian.Garbs.....................................http://www.cgarbs.de

"I'd love to go out with you, but the man on television told me to say
tuned."