Ubuntu
grabcd package

grabcd-encode's script has absurdly generic name

Bug #46447 reported by Colin Watson
6
Affects Status Importance Assigned to Milestone
grabcd (Ubuntu)
Fix Released
Wishlist
Daniel T Chen

Bug Description

-rwxr-xr-x root/root 1777 2006-05-24 19:55:55 ./usr/bin/encode.pl

This is way too generic (and furthermore encodes the implementation language in the file name). This should be /usr/bin/grabcd-encode, probably.

Similarly, grabcd.pl and scancd.pl in grabcd-rip aren't great names, although they aren't so bad (I'd prefer grabcd and grabcd-scancd personally).

Revision history for this message
Daniel T Chen (crimsun) wrote :

also resolves bug 46448

Changed in grabcd:
assignee: nobody → crimsun
importance: Medium → Wishlist
status: New → In Progress
Revision history for this message
Daniel Holbach (dholbach) wrote :

I feel we should discuss this with upstream. There might be scripts that are going to break. :-/

What do you think? The fix for bug 46448 is completely fine.

Revision history for this message
Daniel T Chen (crimsun) wrote : Re: Regarding Ubuntu bug #46447 [grabcd-encode's script has absurdly generic name]

Christian,

The proposed approach sounds quite reasonable. Thanks again!

Dan

----- Original Message ----
From: Christian Garbs <email address hidden>
To: Dan Chen <email address hidden>
Sent: Sunday, December 28, 2008 4:42:47 AM
Subject: Re: Regarding Ubuntu bug #46447 [grabcd-encode's script has absurdly generic name]

On Sat, Dec 27, 2008 at 01:14:23PM -0800, Dan Chen wrote:

> While tending the bug reports for grabcd in Ubuntu, I came across
> this bug[0] that describes the filenames of the main scripts in the
> grabcd source package as being too generic. I made the subsequent
> changes[1] to resolve the bug, but there is concern[2] that such a
> change would break compatibility with existing scripts. While no
> Ubuntu binary packages depend on hardcoded paths provided by
> grabcd's executable scripts, we would like to resolve this bug in a
> manner consistent with upstream's (your) wishes if at all possible.

Hello Dan,

the bus report is right: the script names are terrible.

As the package names are 'grabcd-rib' and 'grabcd-encode', I shall
rename the scripts to:

- grabcd-encode
- grabcd-rip
- grabcd-scan

That way it's consistent among the scripts as well as the package
names.

If the ENCODE_BINARY in the configuration points to the old name
(encode.pl), I will correct it automatically and print out a warning
about it e.g. "encode.pl is now called grabcd-encode, please update
your config, this is corrected for this run".

If you don't find any flaws in this, expect a new version within the
next days.

Regards
Christian
--
....Christian.Garbs.....................................http://www.cgarbs.de

"I'd love to go out with you, but the man on television told me to say
tuned."

Revision history for this message
Daniel Holbach (dholbach) wrote :

Can Christian or you let us know when there's a new upstream version to sponsor? I'm happy to upload it.

Revision history for this message
Daniel Holbach (dholbach) wrote : Unsubscribing Sponsors.

I'm unsubscribing the Sponsors' Team for now. Please re-subscribe when ready.

Revision history for this message
Daniel T Chen (crimsun) wrote :

Daniel, see bug 312566.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks.

Revision history for this message
Daniel T Chen (crimsun) wrote :

fixed version available in jaunty

Changed in grabcd:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.