Comment 6 for bug 492145

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> 2009/12/8 Aaron Bentley <email address hidden>:
>> Ah, this is actually a review request email, and as such there's
>> possible overlap with bug #307461.
>
> Maybe the "you have been subscribed"

It doesn't say "you have been subscribed", it says "You have been
requested to review..." There are no subscriptions on individual merge
proposals, which is a design decision.

> should say something like "...
> which replaces the previous review xxxx"

I suppose we could vary the message depending on whether you've
previously been asked to review, e.g. "You have been requested AGAIN to
review..."?

I don't see how that sort of thing would address your original issue
that the cover letter is stale.

> or something about whether
> the mail is being sent actually because you've been subscribed

Not possible

>, or
> because this is a new review and you're subscribed to all of them?

This mail would not be sent for that reason. It is only sent because
someone has requested you, in particular, to perform a review.

FWIW, there has been some discussion of making the cover letter an
editable field like a bug description, and that would have allowed vila
to update the cover letter as appropriate. Would that fix this bug?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksdpikACgkQ0F+nu1YWqI2MzQCeJbYjZstddBZQJCDbVUoea2ep
SKwAnjXQWGR20DG/2dSKiM9BEC8T41s0
=uXmg
-----END PGP SIGNATURE-----