Provide a way to start doing a review by email from web page.

Bug #307461 reported by Barry Warsaw
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

So I'm looking at a merge proposal that I am not yet a reviewer on, but I
would like to review the branch, or an incremental diff in a comment. I'd
greatly prefer to do my review via email. When I look at the mp, I see my
name under the previous reviewers, but my name is grayed out and i see a link
under the status called [Review]. I also see a (+) Request another review
button.

My natural inclination is to click on the [Review] link, thinking this will
set me up as a Reviewer for the branch, and send me emails containing all the
comment so far. Instead, this link does what it says it does <wink> not what
I want it to do! It gives me a comment field and a status pull down for me to
actually do the review. But at that moment, I don't want to do the review, I
want it to send me the email so I can do the review.

Of course, clicking on (+) Request another review is what I really want to do,
and once I've done that, I'm into the workflow I expect. I think at a minimum
the u/i is leading me down the wrong path here.

Revision history for this message
Barry Warsaw (barry) wrote :

Well, actually no, requesting myself as another reviewer doesn't send me the emails, which is what I really want!

Revision history for this message
Tim Penhey (thumper) wrote :

Would you want the entire conversation?
Would you want them attached to the email? Or separately?

Revision history for this message
Barry Warsaw (barry) wrote :

I think I want the entire conversation up to that point, probably as multiple attachments to a single email. The main use case is to be able to review the code, but the cover letter and diff may be i different comments, and some of the follow up comments might be relevant too. Separate emails are much less convenient (IMO).

Paul Hummer (rockstar)
Changed in launchpad-bazaar:
importance: Undecided → Medium
status: New → Triaged
Aaron Bentley (abentley)
summary: - workflow/ui nit in merge proposals
+ Provide a way to start doing a review by email from web page.
Aaron Bentley (abentley)
tags: added: email
Changed in launchpad:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.