Comment 8 for bug 172501

Revision history for this message
Karl Fogel (kfogel) wrote : Re: reject non-code patch attachements

Abel Deuring and I like Tom's idea in comment #2: if someone attaches something that claims to be a patch, but Launchpad is not able to automatically determine that it really *is* a patch, then insert a confirmation step that asks them if they really mean it's a patch. (The text would link to a canonical definition of "What is a patch?" as mentioned by Jamu Kakar in comment #4.)

@Matt and @Emmet: listing bugs-with-patches is part of https://dev.launchpad.net/Bugs/PatchTracking. IMHO the benefits of an automated solution seem worth trying for; the bugsquad shouldn't have to manually add this tag if we can reliably autodetect the presence of a patch -- either as an attachment, or even in a branch (e.g., bug has a branch attached and that branch gets commits and the bug goes to "fix committed" or "fix released"; while Ubuntu might then have the fix, we also want to make sure upstreams can find out about it and have easy access to it as well).

Note that bug #298099 contains a suggestion for making the "This attachment is a patch" checkbox less error-prone, too.