patch flag for attachments not indicated as optional

Bug #298099 reported by Brian Murray
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Abel Deuring

Bug Description

When adding an attachment to a bug report the attachment field is shown as option and so is the description. However, there is no indication at the checkbox "This attachment is a patch" is optional so it may be checked erroneously by people adding attachments to a bug report. This can then have the affect of adding noise to searches for bugs with attachments.

Jonathan Lange (jml)
tags: added: patch-tracking
Deryck Hodge (deryck)
Changed in malone:
status: New → Triaged
importance: Undecided → High
tags: added: story-patch-project
tags: added: story-patch-report
removed: story-patch-project
Revision history for this message
Karl Fogel (kfogel) wrote :

As mentioned in bug #172501 (comment #8), a way to make this less error prone would be:

- Add a confirmation step when the attachment does not look like a patch.

- Change the text to "this attachment contains a solution (patch) for this bug" or something like that, and have the word "patch" link to a page explaining what a patch is and that more reproduction information (like a screenshot or crash report) is not a patch.

Revision history for this message
Abel Deuring (adeuring) wrote :

The fix for bug 172501 (r10253: double-check when a user sets the patch flag to a value that seems to be inconsistent) should also fix this bug, as Karl notes.

Changed in malone:
status: Triaged → Fix Committed
Deryck Hodge (deryck)
Changed in malone:
milestone: none → 10.02
Karl Fogel (kfogel)
tags: removed: story-patch-report
Deryck Hodge (deryck)
Changed in malone:
assignee: nobody → Abel Deuring (adeuring)
Abel Deuring (adeuring)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.