f-spot should use "standard" credits button icon in About box

Bug #41825 reported by Andy Price
8
Affects Status Importance Assigned to Milestone
F-Spot
Fix Released
Low
f-spot (Ubuntu)
Fix Released
Wishlist
Michael Vogt

Bug Description

Similar to bug #3226 f-spot uses a single star icon on its credits button in the About box. The majority of gnome (gtk) applications I've seen use the icon with 4 stars which seems to be the "standard"

(See arguments in aforementioned Evolution bug)

Related branches

Changed in f-spot:
status: Unconfirmed → Confirmed
Revision history for this message
Bruce Cowan (bruce89-deactivatedaccount) wrote :

The "proper" about box is actually a GNOME goal - http://live.gnome.org/GnomeGoals/AboutDialog .

Revision history for this message
Sitsofe Wheeler (sitsofe) wrote :

Still here in Feisty.

Version information:
Ubuntu Feisty
f-spot 0.3.4-0ubuntu1

Maia Everett (linneris)
Changed in f-spot:
status: Confirmed → Triaged
status: New → Unknown
Revision history for this message
Maia Everett (linneris) wrote :

Reported upstream.

It should be noted that starting with Gutsy, Ubuntu uses a four-pointed star in the default GNOME theme. However, it's nevertheless GTK_STOCK_ABOUT, which F-Spot doesn't use.

Changed in f-spot:
status: Unknown → New
Revision history for this message
Maia Everett (linneris) wrote :

Fixed upstream. I've cherry-picked the fix and modified it for inclusion as a dpatch.

Changed in f-spot:
status: Triaged → Fix Committed
Revision history for this message
Maia Everett (linneris) wrote :

Debdiff with the above patch included.

f-spot (0.4.1-4ubuntu3) hardy; urgency=low

  * debian/patches/45_about-dialog.dpatch:
    - Cherry-picked migration to Gtk.AboutDialog from SVN 3568. (LP: #41825)

 -- Matvey Kozhev <email address hidden> Sat, 19 Jan 2008 13:55:24 +0600

Changed in f-spot:
status: Fix Committed → Confirmed
Changed in f-spot:
status: New → Fix Released
Michael Vogt (mvo)
Changed in f-spot:
assignee: nobody → mvo
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package f-spot - 0.4.1-4ubuntu4

---------------
f-spot (0.4.1-4ubuntu4) hardy; urgency=low

  [ Matvey Kozhev ]
  * debian/patches/45_about-dialog.dpatch:
    - Cherry-picked migration to Gtk.AboutDialog from SVN 3568. (LP: #41825)

  [ Michael Vogt ]
  * debian/patches/50-fix-missing-G_GNUC_FUNCTION.diff:
    - fix ftbfs because of G_GNUC_FUNCTION
  * debian/patches/55-add-mimetype.dpatch:
    Modify the patch by Matvey to register F-Spot in the Media tab
    in the file management preferences (LP: #191475)

 -- Michael Vogt <email address hidden> Thu, 14 Feb 2008 09:50:24 +0100

Changed in f-spot:
status: In Progress → Fix Released
Changed in f-spot:
importance: Unknown → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.