Merge lp:~jamesodhunt/libnih/strchr-fixes into lp:libnih
Status: | Merged |
---|---|
Merged at revision: | 1054 |
Proposed branch: | lp:~jamesodhunt/libnih/strchr-fixes |
Merge into: | lp:libnih |
Diff against target: |
66 lines (+18/-1) 4 files modified
ChangeLog (+14/-0) nih-dbus-tool/tests/test_com.netsplit.Nih.Test_object.c (+1/-0) nih-dbus-tool/tests/test_com.netsplit.Nih.Test_proxy.c (+2/-0) nih/config.c (+1/-1) |
To merge this branch: | bzr merge lp:~jamesodhunt/libnih/strchr-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Scott James Remnant | Pending | ||
Review via email: mp+73431@code.launchpad.net |
Description of the change
* nih-dbus-
case it returns address of null (which would give a misleading test
pass).
* nih-dbus-
before invoking strchr in case it returns address of null (which would
give a misleading test pass).
* nih/config.c (): nih_config_
doesn't return address of null since this would result in a misleading
return value of TRUE.
Hi Scott,
Regarding the comments on: https:/ /code.launchpad .net/~jamesodhu nt/libnih/ fix-for- bug-834813/ +merge/ 73383 wrt existing strchr usage, these were the only instances of strchr() I could find that could return bogus values.
Cheers,
James.