Comment 8 for bug 372632

Revision history for this message
ChrisW (chris-simplistix) wrote :

Okay, just for clarification, Sidnei's fixes were:

http://zope3.pov.lt/trac/changeset/99805
http://zope3.pov.lt/trac/changeset/99806

A few comments:

- The original commits in r92767 shows no signs of unit tests being written. Why was this?

- r99806 also includes no tests. If this commit was needed, where's the test to prove it?

- Some light testing suggests the patches do fix the issue

- Zope 2 no longer support Python 2.4, so I'm not sure we need to special cases for Python 2.4

I'm setting the issue back to "In Progress" until we get more tests for the original changes and r99806.