Comment 7 for bug 330746

Revision history for this message
David Planella (dpm) wrote :

I've created a branch with a proposed fix and I've linked it to the bug.

It basically binds the gettext translation domain when starting the ubuntuone-client, and it gets the required variables (domain, locale dir) from the configuration information. I had a look at how it's done for GNOME python apps and I basically adapted the code from the hamster-applet.

I've got a few questions, though:

* I've defined GETTEXT_PACKAGE="${PACKAGE}" in configure.ac, so that the domain name is the same as the package name and it is set at configure time. However, having had a look at a couple of GNOME python apps, I've seen that they always hardcode the domain name in plain text there (and again in the .py file when binding the domain). I'm not sure which one the preferred way is.

* I've added $(top_srcdir)/canonical/ubuntuone/defs/defs.py.in to EXTRA_DIST in Makefile.am, although $(pyfiles) seems to include _everything_ that's inside the 'canonical' directory in the source tree.

Rodney, what's the next step, does it have to be first reviewed and then proposed for a merge, or the other way round? Where can I find the contributor agreement to sign?