On Mon, Nov 02, 2009 at 07:55:26PM -0000, Bryce Harrington wrote:
> Hey Matt, this looks cool, I'm excited to put it in. One question, is
> this correct:
>
> +DRIVER=="i915, "ACTION=="change", ENV{ERROR}==1,
> PROGRAM="/usr/share/apport/apport-gpu-error-intel"
>
> I notice in the patch the script is named apport-gpu-error-intel.py:
>
> + install -m 755 debian/apport-gpu-error-intel.py
> $(CURDIR)/debian/tmp/usr/share/apport
>
> Should the PROGRAM bit have .py appended to it?
You are correct, PROGRAM should correspond to the path where the script is
installed.
I never managed to test the udev rule, since I couldn't get the kernel to
send the relevant uevent (even when I got a hang). Looks like I botched it.
Thanks for spotting it.
On Mon, Nov 02, 2009 at 07:55:26PM -0000, Bryce Harrington wrote: "/usr/share/ apport/ apport- gpu-error- intel" gpu-error- intel.py: apport- gpu-error- intel.py /debian/ tmp/usr/ share/apport
> Hey Matt, this looks cool, I'm excited to put it in. One question, is
> this correct:
>
> +DRIVER=="i915, "ACTION=="change", ENV{ERROR}==1,
> PROGRAM=
>
> I notice in the patch the script is named apport-
>
> + install -m 755 debian/
> $(CURDIR)
>
> Should the PROGRAM bit have .py appended to it?
You are correct, PROGRAM should correspond to the path where the script is
installed.
I never managed to test the udev rule, since I couldn't get the kernel to
send the relevant uevent (even when I got a hang). Looks like I botched it.
Thanks for spotting it.
--
- mdz