Comment 13 for bug 378617

Revision history for this message
In , Keith Packard (keithp) wrote :

Ok, I found a bunch of little mistakes in the user-mode Display Port code:

 * not actually setting the voltage/pre-emphasis, which would break monitors that couldn't lock onto the lowest voltage/pre-emphasis pair.

 * setting the M/N values after enabling the pipe. This would cause the first attempt to enable the output to fail, as those values are part of the pipe configuration and not loaded except at pipe enable time.

 * Not saving/restoring the M/N registers. This would cause return to text mode to fail if the M/N values needed to change.

I'm pretty happy with the current code; please retest the display-port branch and report back any failures.