Comment 9 for bug 370777

Revision history for this message
Geir Ove Myhr (gomyhr) wrote : Re: [GM45] LeftOf positioning not working anymore with 2.6.3-0ubuntu9.1

Just confirming my suspicion:

From src/common.h:
#define IS_I965G(pI810) (DEVICE_ID(pI810->PciInfo) == PCI_CHIP_I965_G || DEVICE_ID(pI810->PciInfo) == PCI_CHIP_G35_G || DEVICE_ID(pI810->PciInfo) == PCI_CHIP_I965_Q || DEVICE_ID(pI810->PciInfo) == PCI_CHIP_I946_GZ || DEVICE_ID(pI810->PciInfo) == PCI_CHIP_I965_GM || DEVICE_ID(pI810->PciInfo) == PCI_CHIP_I965_GME || IS_G4X(pI810))

So: IS_I965G is true for 965G, G35, 965Q, 946GZ, 965GM, 965GME, G45, GM45, ++

In principle there shouldn be anything wrong with defaulting to Virtual 2048x2048 for other chipsets, but maybe it would be beter to replace IS_I965G with a test for the PCI_ID(s).