Comment 57 for bug 328035

Revision history for this message
Steve Langasek (vorlon) wrote : Re: [Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

On Tue, Mar 24, 2009 at 08:15:56PM -0000, Bryce Harrington wrote:
> Interesting, it seems my initial analysis in comment #5 was not far off.

> For now I've opted to drop the patch with tormod's debdiff in comment
> #51. I've uploaded this, but defer to slangasek's discretion in
> including it for beta. (I favor dropping it in beta myself but know
> that time is short, and while the crashes are serious and may lead to
> some extraneous bug reports during testing, I don't think it's going to
> critically inhibit testing activity.) If it doesn't go in for beta, it
> will go in post-beta.

Either we force retesting of all the ISOs, or we have to advise users to
upgrade X before they can submit meaningful bug reports. If the crashes
only happen once the timestamp overflows (~28h), it's highly unlikely that
this will impact liveCD users; users installing should be tracking the
post-beta updates anyway, and can be explicitly instructed to do so for the
X server as part of the beta errata.

So I'm opting not to reroll the CDs for this, but this change is on the
watch list for things to include if we do have to reroll.

> Meanwhile, it's curious that the code is getting negative timestamps.

Are we sure that it is, rather than simply overflowing the buffer due to
large positive timestamps?

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>