Comment 48 for bug 328035

Revision history for this message
Matt Zimmerman (mdz) wrote : Re: [Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

On Tue, Mar 24, 2009 at 12:27:07PM -0000, Tormod Volden wrote:
> I got suspicious when I saw LogVMessageVerb in the backtrace, which I
> have touched recently myself... Sure enough I did not think about the
> possibility of clocks going backwards (which they sometimes do after
> resume) when I worked on the timestamp stuff and you end up with nice
> timestamps (like below) with no bounds checking. The tmpBuf is
> overflowed and free()'ing it messes up. Sorry.
>
> [-1009303149.602078] (II) AIGLX: Suspending AIGLX clients for VT switch

Thanks very much! I was getting pretty worried about this and hadn't been
able to track it down yet.

> The timestamp patch was supposed to be taken away before Beta anyway.
> Bryce, can you please remove it now, and I will fix the timestamp again
> for later.

Wouldn't it be better to fix the bug than to remove the patch? The
timestamps are useful.

--
 - mdz