Comment 43 for bug 326344

Revision history for this message
Aaron Plattner (aplattner) wrote : Re: [Bug 326344] Re: compiz/kwin freezes on login as of xorg-server 1.5.99.902-0ubuntu2

On Sun, Feb 08, 2009 at 06:19:48AM -0800, Albert Damen wrote:
> Bisecting patches 157 - 160 blames patch 158_raise_maxclients.patch.
>
> Without this patch compiz works fine again on jaunty / nvidia-glx-180.

MAXCLIENTS is defined in resource.h, which is part of the server's ABI.
You can't just change this number without also changing the ABI version and
recompiling any modules that use it. In particular, this change causes
libglx to overrun some memory, corrupting who knows what. While we can
probably work around this particular problem, I don't think we want to get
into the habit of supporting arbitrary unofficial changes to the server
ABI. If you do think the ABI needs to be changed, please discuss it on
<email address hidden>. There's a discussion in progress right
now about how to properly increase MAXCLIENTS without breaking other apps
that rely on having a lot of resource IDs available:

  http://lists.freedesktop.org/archives/xorg-devel/2009-February/000039.html

This patch needs to be reverted.