Comment 3 for bug 274728

Revision history for this message
Bryce Harrington (bryce) wrote :

I reviewed the change timo posted at http://users.tkk.fi/~tjaalton/dpkg/xserver-prop.diff

It's quite a bit of code to change this late in the release. The benefit it brings is to synchronize us with the released API. Given that there's only a few packages that are likely to need this interface, the benefit seems not huge. On the other hand, improved input device configuration is a pretty important feature in this release so benefits to those few packages may well be worth while.

Since this is a patch to the xserver, the risks theoretically include potential for server crashes, yet these changes are localized to clients using the input properties functions. I think any crashes that would be introduced would be pretty evident.

So, with the caveat that all this needs to receive special testing attention since we have limited time left before release, I'll give my +1 on uploading this.