Comment 61 for bug 323041

Revision history for this message
In , Daniel Stone (daniels) wrote :

(In reply to comment #24)
> (In reply to comment #23)
> > so you decided the right thing to do is to break everyone's build so you don't
> > have to wait until the argument is resolved? if there's an argument about the
> > code, sort the argument out first.
>
> OK, here it appears you are saying that i should have checked in crh.po, even
> though the maintainer didn't want it to be checked in.

either you should've:
  * not checked in the Makefile.am hunk or crh.po, or
  * checked in both the Makefile.am hunk and crh.po

if svu's against inclusion of crh.po at this point in time, why would he want a useless Makefile.am hunk to be commit which breaks the build?

> > so you decided to commit your stuff again without feedback or acks from the
> > maintainer? just before the freeze?
>
> And here it appears that you are saying that i should heed to what the
> maintainer is saying.

yes, and you should.

> What i gather is that you are upset that the build was broken during 15 hours,
> but i don't know what exactly you expected me to do: you feedback is
> self-contradictory.

not commit anything which breaks the build. if that depends on something else which you can't commit, then you have to either not commit the other bits or commit them in such a way that they don't break the build.

> And i don't understand what you are saying about the freeze:
> if i didn't check in what i've checked in the last time, those same changes
> would need to be checked in during the freeze for the May 26th release; which
> is probably what Sergey had in mind when he temporarily removed crh from
> configure.in. It appears he pulls .pos from TP on the day of the release; which
> may be fine to previously released locales, but a newly-to-be-supported locale
> also requires configure.in change, which is more significant than just updating
> existing .po files. Are you saying that it would be better to have these
> changes made on the day of the release, as opposed to before the code freeze? I
> respectfully disagree.

when they are committed is svu's decision.

> I hope the fix for this bug can finally be released, and the case closed. I've
> never spent so much time on any other bug in my life.

surprising.