Comment 59 for bug 323041

Revision history for this message
In , Peter Hutterer (peter-hutterer) wrote :

(In reply to comment #21)
> Based on gnome, and other projects, i'm fully aware that the committer needs to
> ensure that buildability is not affected. Given that you cut out the piece that
> stated that, I think you are aware that Sergey mentioned checking .po in as a
> reason for reverting in February. I was simply trying to avoid that kind of
> meaningless conflict again. Not checking in .po when it's sitting on my
> desktop, didn't sound right to me either, but i did it that way to avoid
> another dubious revert situation.

so you decided the right thing to do is to break everyone's build so you don't have to wait until the argument is resolved? if there's an argument about the code, sort the argument out first.

(In reply to comment #22)
> It also makes sense to be able to make a build with the new localization prior
> to code freeze, as opposed to on the day of the release. Therefore, based on
> this feedback, and common sense, i just committed crh.po as well, and added crh
> back to configure.in.

so you decided to commit your stuff again without feedback or acks from the maintainer? just before the freeze?

First, there's a reason why we have a maintainer. if you decide that your stuff is more important than the maintainers opinion don't be surprised if you get your stuff reverted. If you did that in one of the repositories that I maintain, I'd have removed your commit access immediately.

Political issues are non-relevant. You should nonetheless be capable of sorting things out from a technical point of view. The right thing to do is to start a discussion by inviting other ppls viewpoints and now to go over the head of the maintainer.

Look at the original comment in this bugreport. there is zero information and I don't see any attachment for proposed fixes. 5 days later you checked in code that no-one could have checked. why? did you publish the code anywhere else for review or comments?