Comment 57 for bug 323041
Revision history for this message
|
|
#57 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
(In reply to comment #18)
> From the commit msg:
> "In particular, crh.po is not checked in this time, [...] so until it's pulled
> from TP, something like `cp po/tr.po po/crh.po` is required prior to building
> from source."
>
>
> If a manual copy is required to build from source because something is missing
> then DONT COMMIT! I don't care about the reason why it's missing, but if it is
> required for xkeyboard-config to work, then either commit it or leave out the
> whole thing until the issue is resolved completely.
Based on gnome, and other projects, i'm fully aware that the committer needs to ensure that buildability is not affected. Given that you cut out the piece that stated that, I think you are aware that Sergey mentioned checking .po in as a reason for reverting in February. I was simply trying to avoid that kind of meaningless conflict again. Not checking in .po when it's sitting on my desktop, didn't sound right to me either, but i did it that way to avoid another dubious revert situation.