Comment 528 for bug 371897

Revision history for this message
In , Felipe Contreras (felipec) wrote :

(In reply to Ben Klein from comment #404)
> (In reply to Ben Shadwick from comment #403)
> > The Wine devs are so irrationally close-minded about this issue
>
> OK, stop there before this descends into a flame-war.

Stop what? To me this seems to be an accurate description of the actual issue we are facing here.

Ignoring the real issue is not going to get us anywhere.

> > citing of silly procedural issues as an excuse to avoid having
> > to incorporate fixes.
>
> Those "procedural issues" relate to code quality and cooperative
> functionality with other modules. Winepulse is not up to scratch.

I haven't been very involved in the Wine community, but I do recall another bug report about dwrite breaking Steam because it wasn't yet working correctly. Not only was the dwrite code in the source tree, it was enabled by default (it shouldn't be).

If incomplete code known to break important applications is part of source tree, why isn't wine pulse there?

You say there are some "issues" with it. Sure, I can believe there are issues, however, code doesn't have to be perfect in order to be merged.

Most code is merged after all the obvious issues found in code review are addressed, sometimes with known issues and TODO's. Eventually one by one the issues are addressed.

Not merging the code because it's not "perfect" is irrational, and that's a fact.