Comment 53 for bug 93413

Revision history for this message
James Tait (jamestait) wrote :

Panda_N_Shark said:

> I only think that people with need to connect to universities
> connect throw a pix,

I disagree. I know more people who connect to business networks through PIX appliances than University networks. The technology is equally applicable in either situation.

> and to do that i think the solution in post 26 is the best,

I still feel, as Deven Phillips neatly summarised, that this would be a step backward. I'm not sure if it breaks compatibility with network-manager-vpnc or if network-manager-vpnc just doesn't support the new config option -- I haven't checked, although I suspect the latter -- but either way I would suggest that this would be a bug in network-manager-vpnc rather than in vpnc itself.

> or solve the problem that new patch create, because graphical is more
> easy to new commers to ubuntu.

Agreed, and this is the reason Bug #112406 was opened by Alexander Papaspyrou. However, there's little point working towards implementing UI support for a new feature in vpnc if that feature is never going to be implemented.

TomasHnyk said 53 minutes ago: (permalink)

> Also, the broken code should be rather fixed upstream,

Agreed, but I'm not involved with the upstream project (can someone point me at their home page and CVS?) and not familiar with how Ubuntu patches are propagated upstream. I'm new to all of this. I seem to remember seeing in changelogs that patches have been applied at the Ubuntu level, then later reverted when the upstream project has applied them. Maybe that is what needs to happen here, I don't know -- hence my questions above.

> disabling it
> during compiling is only a workaround, not a solution.

Absolutely agreed, which is why I submitted the patch for the config option. Technically, IMO, this is still a work-around but a cleaner solution than disabling DPD for everyone.

> I would also call
> for downgrading for the reasons mentioned above (plus the pacakge is
> tested - however, we need to look if there were any bugs solved by
> 3.3>4.0 upgrade in Ubuntu.)

Not bug fixes as such, but:

  * New upstream release
    + GNU/kFreeBSD related fixes (closes: #400740)
    + Supports phase2 rekeying (closes: #411108)
    + auto-creating /var/run/vpnc (closes: #403783)
  * Old config handling extensions replaced with wrappers to upstream
    vpnc-script function variables which are declared official now
    (closes: #399131)
  * more connect/shutdown hooks (closes: #366257)
  * not depending on iproute, though old extensions may not work without it
    but users are warned in that case (closes: #393848)

I'd suggest that there are enough feature enhancements in there to support sticking with the current version, which was considered good enough for release with Feisty.

I'm not just pushing this solution because I want to see my patch included, I have nothing to lose by its rejection, I just think it's the best solution so far proposed.