Comment 4 for bug 215784

Revision history for this message
Daniel J Blueman (danielblueman) wrote :

I hit this bug again, and I would say it represents a major usability problem for VLC, itself a prime desktop app.

VLC does a 'dumb' substitution of the '+' symbol with space in the source, which breaks URL parsing; I expect this was added as a hack previously, when apps didn't use '%20' to represent the space in an RFC-compliant manner.

Fix is thus:

--- src/input/input.c~ 2008-08-25 12:37:44.943073369 +0100
+++ src/input/input.c 2008-08-25 12:37:44.948073326 +0100
@@ -2420,11 +2420,6 @@

             *psz++ = strtol( val, NULL, 16 );
         }
- else if( *p == '+' )
- {
- *psz++ = ' ';
- p++;
- }
         else
         {
             *psz++ = *p++;