Comment 30 for bug 187048

On Tue, May 6, 2008 at 12:28 AM, Martin Pitt <email address hidden> wrote:
> You need to use
> msg = _('...')
> error(msg)

Thanks Martin. Admittedly, I was afraid of the i18n'ing of this, so
I'm not surprised there was a hiccup.

I'll leave this for Soren to fix, since he has commit access and can
knock this out trivially.

> However, Dustin's latest patch only tests for kvm membership. Weren't
> some of the reports due to not being in "libvirtd"? Or is
> http://launchpadlibrarian.net/13880679/virt-manager-check-groups.debdiff
> required in addition to http://launchpadlibrarian.net/14055096/virt-
> manager_test_kvm_perms.debdiff ?

Attachment 13880679 is deprecated by the latest version.

libvirtd membership is needed to attach to the qemu:///system instance only.

Note the conditional checks that the connection is to the
qemu:///session instance:
    if self.connection.get_uri() == "qemu:///session" and
self.get_domain_type() == "kvm":

Soren, perhaps we should have an elif that checks
self.connection.get_uri() == "qemu:///system" and checks libvirtd
membership, throwing up a similar error message in that case. Your
thoughts?

:-Dustin