Comment 9 for bug 497883

Revision history for this message
Karl Lattimer (karl-qdh) wrote :

Applied patch in the wrong order and generated a lot of errors... Moving on there is a problem with the patch in that;

@@ -107,8 +114,8 @@ vino-marshal.c: vino-marshal.list $(GLIB_GENMARSHAL)
 vino_enum_headers = \
  $(top_srcdir)/server/vino-server.h \
  $(top_srcdir)/server/vino-prompt.h \
- $(top_srcdir)/server/vino-status-icon.h \
- $(top_srcdir)/server/vino-status-tube-icon.h \
+ $(top_srcdir)/server/vino-icon-visibility.h \
+ $(top_srcdir)/server/vino-tube-icon-visibility.h \
  $(NULL)

 vino-enums.c: @REBUILD@ $(vino_enum_headers)

excludes the vino-status-icon header file from being scanned by glib-mkenums

@Travis, could you explain your reasoning behind this, and how you failed to be stung with;

vino-status-icon.c: In function ‘vino_status_icon_class_init’:
vino-status-icon.c:547: error: ‘VINO_TYPE_ICON_VISIBILITY’ undeclared (first use in this function)
vino-status-icon.c:547: error: (Each undeclared identifier is reported only once
vino-status-icon.c:547: error: for each function it appears in.)