Comment 12 for bug 560114

Revision history for this message
Colin Watson (cjwatson) wrote :

No, simply removing that line or making it RTL-specific doesn't make sense, I'm afraid. Either layout.set_width is needed in all languages, or it isn't needed in any languages: it doesn't make sense for it to be LTR-specific. It *does* affect LTR languages; if you boot to a live CD desktop ("Try Ubuntu") in current Oneiric, comment out the layout.set_width line in /usr/lib/ubiquity/ubiquity/frontend/gtk_ui.py, run ubiquity, and go to the second page in English, you'll see that the layout of the "Ubuntu uses third-party software ..." label is poor: it doesn't use the full width of the window as it should. This is, as I understand it, exactly the problem Evan was trying to solve with this function.

It looks to me as though what's happening is that we're setting the correct width in the RTL case, but the left-hand X coordinate for the layout isn't being updated to match, so the layout overflows the right-hand side of the screen. Could you look at fixing this instead?

This may well be moot for Oneiric anyway, since we should be on GTK+ 3 by then, but it wouldn't hurt to investigate this in the meantime.