Comment 11 for bug 247867

Revision history for this message
Sveinung Kvilhaugsvik (kvilhaugsvik) wrote : Re: [Bug 247867] Re: Please merge Torbutton 1.2.0~rc5-1 (universe) from Debian unstable (main)

> 1.) I would change "debian/iceweasel-torbutton.* are still
> debian/firefox-torbutton.*". In previous upload, we changed them to
> torbutton-extension.*, so you can keep that message:
> * Modification of debian/iceweasel-torbutton.dirs,
> debian/iceweasel-torbutton.install and debian/iceweasel-torbutton.links
> to take into account firefox extensions directory and renaming them
> to the new binary package schema (torbutton-extension.*)
> In this upload, we are removing iceweasel-torbutton.*, so that
> shouldn't be mentioned in "Remaining Ubuntu changes" part, but as a
> new change:
> * Remove iceweasel-torbutton.*, since Ubuntu doesn't ship Iceweasel
Not sure if I understood that one correct. If iceweasel-torbutton.*
already have been moved (in a previous Ubuntu version), how can you
remove it now but keep its new location? Isn't that a remaining change
from Ubuntu? I did add those entries to the changelog anyway, since it
could be you wanted to record the changes in this from the new Debian
AND from the old Ubuntu package, but it would be nice to know if I
understood you correct.

> 2.) "Link into where Firefox, not Iceweacel, looks" has a typo. Should
> be "Iceweasel"
>
> 3.) "Depend on Firfox 3 and 2 instead of Iceweacel" has typos. Should
> be "Firefox" and "Iceweasel". Also, I think it's correct to say
> "Firefox 3 or 2", instead of using "and".
Fixed. (Sorry about those. I believed that Lintian included a spell checker)

> 4.) Check if the debdiff has an empty line at the end (line #162). If
> it has, please remove it.
Removed

Thank you for your review :)
Sveinung Kvilhaugsvik