Comment 10 for bug 247867

Revision history for this message
Saša Bodiroža (jazzva) wrote : Re: [Bug 247867] Re: Please merge Torbutton 1.2.0~rc5-1 (universe) from Debian unstable (main)

Hello Sveinung,

I have look into this debdiff and it looks good. The needed changes
are mostly correction of typos and maybe rewording in changelog entry
in order to make it more clear:

1.) I would change "debian/iceweasel-torbutton.* are still
debian/firefox-torbutton.*". In previous upload, we changed them to
torbutton-extension.*, so you can keep that message:
* Modification of debian/iceweasel-torbutton.dirs,
  debian/iceweasel-torbutton.install and debian/iceweasel-torbutton.links
  to take into account firefox extensions directory and renaming them
  to the new binary package schema (torbutton-extension.*)
In this upload, we are removing iceweasel-torbutton.*, so that
shouldn't be mentioned in "Remaining Ubuntu changes" part, but as a
new change:
* Remove iceweasel-torbutton.*, since Ubuntu doesn't ship Iceweasel

2.) "Link into where Firefox, not Iceweacel, looks" has a typo. Should
be "Iceweasel"

3.) "Depend on Firfox 3 and 2 instead of Iceweacel" has typos. Should
be "Firefox" and "Iceweasel". Also, I think it's correct to say
"Firefox 3 or 2", instead of using "and".

4.) Check if the debdiff has an empty line at the end (line #162). If
it has, please remove it.

Thank you for your work :).