Ubuntu
thunderbird package

  1. Bug #261595
  2. Comment #47

Comment 47 for bug 261595

Revision history for this message
In , Irving (irving) wrote :

Comment on attachment 756486
Write updated popstate in tempfile first, then move over

Review of attachment 756486:
-----------------------------------------------------------------

Thanks so much for the patch; sorry it took so long for me to review it.

I'm OK with either landing this patch as is, or expanding it to refactor out the other places in mailnews where we create safe, buffered output streams.

::: mailnews/base/util/nsMsgUtils.cpp
@@ +1438,4 @@
> return rv;
> }
>
> +nsresult MsgNewSafeBufferedFileOutputStream(nsIOutputStream **aResult,

There are a couple of other places in mailnews where we're creating safe output streams; it would be great to update those to use this helper function instead of repeating the code, as part of this patch.