Comment 5 for bug 174290

Revision history for this message
Alexander Sack (asac) wrote :

thanks for this. A few comments right away:

1. please generate control file in a separate rule that isn't run automatically. The build should fail if there are locales in the control file that aren't in the .xpi file
1a. maybe print a warning if there are locales in the .xpi which don't have a control file entry.

2. use cp instead of ln to create the post* files during build

3. the var/lib/mozilla-thunderbird/extensions.d business isn't needed since tbird/ffox 1.5 anymore ... you can just drop that.

4. move the templates you currently include in the scripts (e.g . cat << EOF) to .tmpl files

5. use lightningmaxVERSION=0.7.* instead of 0.8