Comment 3 for bug 263269

Revision history for this message
Saivann Carignan (oxmosys) wrote :

Pietro Battiston : Thanks for your work. I reviewed your patch and I see that you changed the icon for a absolute path. While this solution works, I've seen that the GNOME icon cache is generally prefered to absolute icons path (probably for better performances and to be more standard, I guess). Thus, I would recommend to base your work on the patch that I attached on bug 250887 and which is already sent to debian.

Also, there are other changes included in the .desktop file as I see! Is there a specific reason for the new category? If not absolutely necessary, I would suggest these changes to be dropped to make sure that your patch gets accepted.

Also for the translations that you added, please forward your patch to debian, since we sync this package from debian. Fixing this problem in ubuntu is only a temporary solution.

Finally, your patch does not have a changelog entry. You should update the debian/changelog file and mention all changes you made into the package, and this into the description so the bug gets automatically closed : (LP: #250887) (You can look at my patch if you want a example).

Do you think that you can take that before september 25th ? Don't hesitate to ask me if you don't have time to complete the patch ;-) Thanks for the work you've done so far!