Comment 15 for bug 159712

Revision history for this message
Sebastien Bacher (seb128) wrote :

The version with the changes didn't build, I had the details when I commented but it took you 6 weeks to reply and I didn't note those. The other day I was quite busy and just commented quickly, detailling now the issues with your changes

The first debdiff you attached doesn't build,

"uudecode -o debian/usr/share/icons/hicolor/22x22/apps/gnome-dev-cdrom-audio.png debian/icons.gnome-dev-cdrom-audio.png.uue
uudecode: debian/icons.gnome-dev-cdrom-audio.png.uue: Unknown system error"

The icon source filename use a dot wrongly, which is the typo I was speaking about, not sure how it built for you

The new debdiff has some issues too, what version of Ubuntu do you use? The hardy cdbs Depends on intltool and serpentine Build-Depends on cdbs, so intltool should be installed without requiring your change.

Why did you add a "debian/icons/gnome-dev-cdrom-audio.png" rules target rather than just using the binary-install one?

The first change with the clean target added and without the typo would be correct