Comment 2 for bug 538369

Revision history for this message
Benjamin Drung (bdrung) wrote :

1. The deprecated_gtk_macros patch failed to apply.
2. The patch didn't have a DEP-3 [1] header. Did you forward the patch to upstream?
3. -0ubuntu0 is useless in the replace field. You should use 0.136u1 instead of 0.136u1-0ubuntu0. Looking at debian/changelog it probably should be 0.136 instead of 0.136u1.
4. Are there plans for getting the man pages upstream?
5. You can remove debian/README.source
6. There are some lintian complains:
E: mame: description-starts-with-package-name
W: mame: games-package-should-be-section-games
I: mame source: duplicate-short-description sdlmame sdlmame-tools
I: mame: extended-description-is-probably-too-short
I: mame-common: extended-description-is-probably-too-short
I: mame: hyphen-used-as-minus-sign usr/share/man/man1/mame.1.gz:913
I: mame-common: package-contains-empty-directory usr/share/doc/mame-common/keymaps/
I: mame: spelling-error-in-binary ./usr/games/mame Continous Continuous
I: mame: spelling-error-in-binary ./usr/games/mame Guage Gauge
I: mame: spelling-error-in-binary ./usr/games/mame Guage Gauge
I: mame: spelling-error-in-binary ./usr/games/mame Independant Independent
I: mame: spelling-error-in-binary ./usr/games/mame Unkown Unknown
I: mame: spelling-error-in-binary ./usr/games/mame Treshold Threshold
I: mame-tools: spelling-error-in-binary ./usr/bin/jedutil succesfully successfully

Some recommendations:
7. Please add a '.patch' suffix to the patches
8. You can use .tar.bz2 instead of .tar.gz (in the get-orig-source rule)
9. You could wrap and sort Build-Depends and Depends in debian/control (makes reading patches easier)

Some suggestions:
10. You could upgrade from debhelper 5 to the short version of debhelper 7 (with the override rules)
11. You could update debian/copyright to use DEP-5 [2]

Please resubscribe ubuntu-sponsors once you have addressed at least the point one till nine.

[1] http://dep.debian.net/deps/dep3/
[2] http://dep.debian.net/deps/dep5/