Ubuntu
rss-glx package

  1. Bug #129142
  2. Comment #20

Comment 20 for bug 129142

Revision history for this message
Jussi Kivilinna (jukivili) wrote : Re: [Bug 129142] Re: Really Slick Screensavers use 100% CPU

Quoting "Tormod Volden" <email address hidden>:

> Please make a new "real" ubuntu version in the changelog, i.e. ubuntu3,
> so that your patch can be applied and uploaded as is.
>

Oh, ok. First time sending deb package updates :)

> A few comments and questions (I just had a quick look at the patch
> and haven't checked the code, and you're definitely more proficient
> at c++ than I am):
> - it's easier to see what you change on the Build-Depends line if
> you just add dpatch to the end.

Ok.

> - the changelog entry might need a colon after LP, like "LP: #bug number".

Ok.

> - there's two variables "now", one double, one timeval.

Renamed 'now' in the new function getSeconds.

> - the boolean expression "optarg != NULL" might as well be written
> "optarg" (question of taste I guess)

Ok, should follow code style of project, omitted "!= NULL".

> - if you define DEFAULT_FPS to 50, do you need the ==0 logic
> guarding just after it?

In case some user wants to change DEFAULT_FPS and sets it to zero, so guard
against division by zero.