Comment 13 for bug 257007

Revision history for this message
James Westby (james-w) wrote :

Hi Hew,

Thanks for the debdiff, and thanks to Jef for sending the patch.

There is one blocker before I sponsor it though. If you look at
your debdiff carefully you will see that the lines you introduced
are apparently indented differently to the lines that are already
there. I believe this is because the originial file uses tabs, and
your change uses spaces, which is bad in python. Please also
check Jef's original patch and warn him if he was the one to
mix tabs and spaces.

I'm unable to access upstream's bug tracker to check if the
file is attached there. If you can access it could you check please?
It's not so important if Jef takes over maintenance, as he will
obviously know about the patch.

Also, it would be nice to forward this change to Debian. If upstream
is dead then they might like to add the patch themselves. However,
the maintainer appears to be a little inactive. Obviously feel free
to send any other changes made to the package in Ubuntu that way
at the same time.

Feel free to ping me on IRC as you attach an updated patch to the bug
report, and I'll upload.

Thanks,

James