Comment 12 for bug 257007

Revision history for this message
Hew (hew) wrote :

Jef Spaleta contacted me with a patch, saying the same issue exists in Fedora. I have converted it into the attached debdiff and subscribed u-u-s. Thanks Jef for the patch! Here is his message:

Morning!

I've hit the same revelation-applet bug in Fedora as you've seen in Ubuntu.

I'm using this patch to class ImageMenuItem in ui.py:

                children=self.get_children()
                if len(children) > 0 : self.label = children[0]
                if len(children) > 1 : self.image = children[1]

See attachment for the actual diff.

Basically what's happen is that some ImageMenuItems have an image
defined and sometimes they don't.
I think gtk use to pass None as the second child in the list for all
situations, but now, it doesn't populate the second child in these
cases.

My patch tries to be robust, but not optimal.

I'll be submitting the patch to upstream, but upstream is practically
dead. I might be looking to take over the upstream development of
revelation but I can't do it until the start of the new calendar year.

-jef