Comment 52 for bug 156085

Revision history for this message
TJ (tj) wrote :

Let's try that again!

The 32-bit PPA builds failed because the debian/rules file had yet another missing clean rule, this time for extboot/. The effect was that as I'm testing on 64-bit "extboot/signrom" was a 64-bit ELF that would, of course, fail on a 32-bit buildd. I failed to test locally in a 32-bit pbuilder, trying to cut corners.

Secondly, I realised I'd made a major programming boo-boo despite knowing better - requesting an allocation of memory in the host USB file-system scan function, forgetting that the function isn't just called once but repeatedly. That would have led to orphaned memory allocations each time a USB scan or open operation occurred - baaad!

I've also changed the logic so it only scans for the USB file-system type the first time. After that it works off stored values.

Uploads to my PPA for Gutsy, Hardy and Intrepid.

=== changelog ===
kvm (1:74+dfsg-0ubuntu2~ppa2h) hardy; urgency=low

  * Fix: update patch 11: Don't detect host USB file-system location more than once.
  * Fix: debian/rules: add missing make extboot clean (fixes signrom failures
       due to previously built binary remaining - which can be for a different
       architecture).

 -- TJ <email address hidden> Thu, 4 Sep 2008 23:30:00 +0100