Comment 10 for bug 312462

Revision history for this message
BenjaminBerg (benjamin-sipsolutions) wrote :

Hm, just a note. I don't think that the python version of the function should even have the "length" parameter, unfortunately, it might be hard to remove it at this point (it could instead be just ignored, and made optional).

The bindings should just call len(data) themselves, instead of leaving it to the binding user. This is a) less work for the user of the library and b) fixes potential problems where the passed in length is wrong (which could potentially cause crashes inside Poppler, I expect).