Comment 8 for bug 245620

Revision history for this message
In , Marek Kašík (mkasik) wrote :

Created attachment 92928
Respect orientation when selecting words

Attached is a patch which improves selection of words when PDF is rotated by multiples of 90°. It sets correct bounds on various visit*() functions.

The patch doesn't solve all problems related to this. There are still problems with order of selected lines and blocks when multiple blocks are selected.

The problem with correct order of lines is easier to fix but I have not a patch ready yet. The problem with correct order of blocks is a little bit harder since it needs to correct flows.

The main problem why I started to look into this was that poppler shows this warning on some PDFs (see next attachment):

*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug

Btw, the patch doesn't fix the problem shown on the Pedro's screenshot but it is related to the name of this bug.