Comment 2 for bug 512146

Revision history for this message
Alexander Sack (asac) wrote :

taking this as i am assinged to pstoedit too (which requires this).

same old story: add ABI/API tracking facitilies: .symbols is the preferred way to do that.

also upstream wise a few important warnings we might want to fix:

definitly fix :

gram.yy: In function 'char* do_sprintf(const char*, const double*, int)':
gram.yy:1836: warning: format not a string literal and no format arguments

also check:

gram.yy:347: warning: ignoring return value of 'int system(const char*)', declared with attribute warn_unused_result

g_alab_her.c: In function 'label_width_hershey':
g_alab_her.c:404: warning: 'character' may be used uninitialized in this function
g_alab_her.c: In function '_pl_g_draw_hershey_string':
g_alab_her.c:684: warning: 'character' may be used uninitialized in this function
g_alab_her.c:684: warning: 'accent' may be used uninitialized in this function

also if possible run test/ (if you can run those automated during build)