Ubuntu
pcmanx-gtk2 package

  1. Bug #482944
  2. Comment #3

Comment 3 for bug 482944

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote : Re: Please merge pcmanx-gtk2 0.3.8-3 (universe) from Debian testing (main)

Nice job: it's a complex merge, and it seems to be done very well.
I only have some comments on the debdiff:
- why do you delete part of the patch iceape-dev.dpatch ? You don't apply it after, so it could stay as-is
- instead of duplicating almost the full content of the patch iceape-dev.dpatch, I would have made a smaller patch on the top of this patch
- there are 2 translation files in your debdiff. They shouldn't be there

Otherwise, looks good.

Thanks to fix those small issues.

Fabrice