Comment 89 for bug 457220

The expression in the if statement in comment #16 indeed looks a bit odd. It contains

  aWW8AttrFnTab[ nWhich - RES_CHRATR_BEGIN ]

so hopefully nWhich should be >= RES_CHRATR_BEGIN otherwise that will index aWW8AttrFnTab way out of its bounds.

then a bit later in the expression it contains

  nWhich >= RES_CHRATR_BEGIN

(twice) i.e. a subexpression that one hopes should always be true (or indeed cause a crash in the array indexing earlier).