Comment 4 for bug 604717

+ test -f /etc/default/ntp && ./etc/default/ntp || true

Missing a space between '.' and '/etc/default/ntp'. This is probably why you had to add the '|| true' - remove that. Also, to match the init script this should be test -r not test -f.

+ test -e /var/lib/ntp.conf.dhcp && NTPD_OPTS="$NTPD_OPTS -c /var/lib/ntp/ntp.conf.dhcp"

The first filename is typoed - should be /var/lib/ntp/ntp.conf.dhcp.

You only seem to have ported part of the locking code over. You need the backgrounded lockfile-touch and the kill as well (otherwise the lock could time out on a very slow start), although quite how you're going to get the pid of the lockfile-touch process across to the post-start script I'm not quite sure.

Please try to avoid the use of a pidfile. Upstart's process tracking should be sufficient.

The apparmor code in the Upstart job appears to be new relative to the init script. Why?