Comment 6 for bug 1182586

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Thanks for the debdiffs! In general, they are fine, but a couple of nitpicks for future updates:
 * for consistency, the format of the changelog should use 'SECURITY UPDATE', not 'Security update' and follow the changelog format as described in https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Packaging
 * it isn't required, but normally you will use a '-' rather than a '*' for subentries in the changelog (eg you would use "- Patch to fix a buffer overflow vulnerability (CVE-2013-2070)"
 * you should use simply 'LP: #1182586', not 'closes LP: #1182586'
 * I encourage people to give more detail in the changelog

Eg, if I were writing this I would might write:

nginx (1.1.19-1ubuntu0.2) precise-security; urgency=low

  * SECURITY UPDATE: fix a buffer overflow via proxy_pass
     - debian/patches/cve-2013-2070.patch: verify ctx->size and ctx->length in
        src/http/modules/ngx_http_proxy_module.c
     - LP: #1182586

Builds fine with no new compiler errors/warnings. ACK