Comment 6 for bug 643289

Revision history for this message
James Hunt (jamesodhunt) wrote :

@Steve - I've performed a code review of the 2 patches. Aside from a few minor formatting suggestions for mountall.diff (#2), they look good:

mountall.c:162: indent of 'handler' element should align with 'mnt'.
mountall.c:1559: Suggest comment changed to, "All mounts have been attempted, so wait for pending events."
mountall.c:1682: add space after nih_info and before '('.
mountall.c:1685: add space after nih_info and before '('.
mountall.c:1694: add space after nih_info and before '('.
mountall.c:1697: add space after nih_info and before '('.
mountall.c:2349: add space after NIH_MUST and before '('. Ditto for nih_alloc.

I've also done a very quick "sniff test" on a natty system patched to incorporate both patches. The test system was not configured for NFS, so clearly further testing is required on this front. However, the system boots and the async mounts appear to work correctly.

Full testing clearly requires the NFS scenario described. Additionally, consideration needs to be given to the following questions:

- what happens when an fsck fails?
- what happens if a swap image is corrupt?
- how will this impact mountall in initramfs?
  (https://blueprints.launchpad.net/ubuntu/+spec/packageselection-foundations-n-event-based-initramfs)