Comment 144 for bug 330824

Revision history for this message
Theodore Ts'o (tytso) wrote :

Saïvann,

Thank you very much for doing the bisect and confirming Carey's results. The problem with this is that the commit that you figured as causing the problem, dbf8b1c4, is identical to commit 82eb4869, which appeared in 2.6.28.7, and commit 920313a7, which appeared in 2.6.29-rc1, and so was in 2.6.29. And users of stock 2.6.28.8 and 2.6.29 kernels have reported that the issue reported in this bug have gone away.

So as I had said earlier, this looks like it's a combination of multiple patches that are necessary to cause this problem, and it's not just commit dbf8b1c4. OK, so what I've done is the following. I ran the command "git log --reverse --pretty=oneline --abbrev-commit --abbrev=8 v2.6.28.. fs/ext4 fs/jbd2" on the Jaunty kernel git tree, and extracted the list of commits that touched the fs/ext4 and fs/jbd2 kernel. There are only 10 of these patches between 2.6.28 and commit dbf8b1c4 (including dbf8b1c4). I then did a "for i in `cat /tmp/clist`; do git cherry-pick $i; done" to create a kernel tree which *only* has the Ubuntu sauce patches that touched the fs/ext4 and fs/jbd2 trees.

I've exported this as branch "ubuntu-330824-test" on my ext4.git tree. Unfortunately, it looks like master.kernel.org is being slow to mirror out changes to git.kernel.org, so if you're not seeing at:

     http://git.kernel.org/?p=linux/kernel/git/tytso/ext4.git
     git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git

I've also pushed the branch ubuntu-330824-test to:

    http://github.com/tytso/ext4/tree/ubuntu-330824-test
    git://github.com/tytso/ext4.git

Saïvann, can you give this tree a try? If it works, then the problem must be an interaction with one of the *other* Sauce patches between v2.6.28 and dbf8b1c4, and that may be a very large haystack. If you get a failure (i.e., you can reproduce the bug), then the problem must be in one of the ten commits on ubuntu-330824-test. Obviously, a failure is preferable since it will be easier haystack with 10 commits than it will be to find the problem in a haystack with 700 commits. :-)

Either way, though, it should give us more information.

Thanks for the work you've done so far,