Comment 138 for bug 330824

Revision history for this message
Pauli Virtanen (pauli-virtanen) wrote :

@Tim Gardner on 2009-04-30:
> @Derek - that patch is already in Jaunty.
>
> static void ext4_mb_add_n_trim(struct ext4_allocation_context *ac)
> ...
> list_for_each_entry_rcu(tmp_pa, &lg->lg_prealloc_list[order],
> pa_inode_list) {
> spin_lock(&tmp_pa->pa_lock);
> if (tmp_pa->pa_deleted) {
> ....

I don't think it is: currently in git://kernel.ubuntu.com/ubuntu/ubuntu-jaunty.git (or is the current Jaunty kernel tree somewhere else?), fs/ext4/mballoc.c reads

http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-jaunty.git;a=blob;f=fs/ext4/mballoc.c;h=add854a140a1c3b0207daaaab0e92d3cca5bb882;hb=HEAD#l4418
                ...
                spin_lock(&tmp_pa->pa_lock);
                if (tmp_pa->pa_deleted) {
                        spin_unlock(&pa->pa_lock);
                        continue;
                }
                ...

while in mainline also the latter pa-> is tmp_pa->. Same for the linux-image-2.6.28-11-generic 2.6.28-11.42 tarball.

Has anyone tried to reproduce the bug with this change applied?